[PATCH] D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic).

Tue Jun 21 23:32:25 PDT 2022

dblaikie added a comment.

In D126835#3600547 <https://reviews.llvm.org/D126835#3600547>, @ayermolo wrote:

> In D126835#3600524 <https://reviews.llvm.org/D126835#3600524>, @dblaikie wrote:
>
>> Looks like this would be another issue with zero-length symbols: https://reviews.llvm.org/D127897 (just cross-referencing/collating)
>
> Well it's an issue right now even without this change.

Sorry, what I meant is: This issue (D126835 <https://reviews.llvm.org/D126835>) and the other (D127897 <https://reviews.llvm.org/D127897>) would probably both be better-off solved by changing the compiler/LLVM to never produce zero-length entries.

> Long term @zr33 (our summer intern) is working on mechanism to write out .debug_Info/.debug_abbrev using the same mechanics as in codegen/dwarflinker.
> Once that is enabled we can leave this pattern as is without converting to ranges.

Still not really following - "converting to ranges" as in "changing consumers to use ranges instead of aranges"? sure - though I think that change would be a good thing in general, since aranges take up a bunch of object space.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126835/new/

https://reviews.llvm.org/D126835