[PATCH] D128094: [WebAssembly][Object] Remove requirement that objects must have code sections

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

In D128094#3593734 <https://reviews.llvm.org/D128094#3593734>, @aheejin wrote:

>> (Also we can't just always require the presence of e.g. the
>> function or global sections, because a binary may just have any functions.
>> There's only an problem if the name or linking section tries to name a
>> nonexistent function).
>
> Code LGTM, but not sure what this sentence means.. Can you provide a little more context?

Oops, that should say "a binary may just *not* have any functions." (or globals). In other words, we could try replacing the requirement that we've seen the code section with a requirement that we've seen the Function section; but there still could be perfectly valid wasm binaries with not function section (or maybe we want to be able to parse binaries that only have custom sections and no functions, and we don't care about validation).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128094/new/

https://reviews.llvm.org/D128094