[PATCH] D124798: [Symbolize] Parse multi-line markup elements.

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 15:51:58 PDT 2022


mysterymath updated this revision to Diff 438855.
mysterymath added a comment.

Refactor markup parser to parse lazily on each node request.

With the semantic changes to parseLine() in the previous change, this only
requires a slight modifification to the parsing algorithm. This has the
advantage that only the portion of the line that is actually used is parsed,
which is advantageous for context lines, where any suffix of the context
element is summarily discarded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124798/new/

https://reviews.llvm.org/D124798

Files:
  llvm/include/llvm/DebugInfo/Symbolize/Markup.h
  llvm/lib/DebugInfo/Symbolize/Markup.cpp
  llvm/unittests/DebugInfo/Symbolizer/MarkupTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124798.438855.patch
Type: text/x-patch
Size: 11309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220621/5408cc8b/attachment.bin>


More information about the llvm-commits mailing list