[PATCH] D127491: [JITLink][Orc] Add MemoryMapper interface with InProcess implementation

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 14:50:47 PDT 2022


sgraenitz added a comment.

Thanks for taking care of reverting.

The issue is that MSVC's `std::future` implementation requires default constructible types. It's a known issue, but I had not thought about it during the review. When defining a `std::promise` we have to use `MSVCPError` and `MSVCPExpected<T>` instead of `Error` and `Expected<T>` respectively. I will fix it and re-apply the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127491/new/

https://reviews.llvm.org/D127491



More information about the llvm-commits mailing list