[PATCH] D115747: [AMDGPU] Flush the vmcnt counter in loop preheader when necessary

Baptiste Saleil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 14:23:33 PDT 2022


bsaleil updated this revision to Diff 438835.
bsaleil added a comment.

Addressed review comments: Use ranges in `for` loop and split `generateWaitcntInstBefore` to reuse its second half for `generateWaitcntBlockEnd`.
Also changed `applyPreexistingWaitcnt` to take a `MachineBasicBlock::instr_iterator` instead of a `MachineBasicBlock::iterator` to match the caller.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115747/new/

https://reviews.llvm.org/D115747

Files:
  llvm/include/llvm/CodeGen/MachineBasicBlock.h
  llvm/lib/CodeGen/MachineBasicBlock.cpp
  llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/CodeGen/AMDGPU/waitcnt-vmcnt-loop.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115747.438835.patch
Type: text/x-patch
Size: 37919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220621/238e8e21/attachment.bin>


More information about the llvm-commits mailing list