[PATCH] D125263: [CMake][MSVC] Compile with `/permissive-`

Tue Jun 21 14:09:47 PDT 2022

aeubanks added a comment.

In D125263#3600222 <https://reviews.llvm.org/D125263#3600222>, @paulkirth wrote:

> @aeubanks That was my first thought too, but I think there may be something more subtle going on here with the `/permissive-` flag that is causing the underlying issue.  AFAICT from the documentation linked in the summary, it shouldn't change how things are included, and this is compiling fine on other platforms. My guess is that `clang-cl` isn't handling this flag the same way as MSVC, and thus things like `/Zc:rvalueCast` aren't set correctly.
>
> Windows isn't a platform I'm that well versed on, so I'm happy to defer, but if there is a subtle thing happening here, I'd rather us look into it now than try to diagnose some subtle thing down the line.
>
> Anyway, if that makes our bots green, I'll let you know.

`/Zc:rvalueCast` seems to be ignored within clang-cl so I don't think that's the issue.
https://github.com/llvm/llvm-project/blob/1c2b756cd6f9f9408863fb0e91f55731f81b46d9/clang/include/clang/Driver/Options.td#L6730

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125263/new/

https://reviews.llvm.org/D125263