[PATCH] D128302: [LICM][AArch64] Detects that ExtractElement is not free in AArch64 when deciding whether to sink an operation in the exiting block of a loop.
Mingming Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 14:09:25 PDT 2022
mingmingl added a comment.
In D128302#3600211 <https://reviews.llvm.org/D128302#3600211>, @nikic wrote:
> Changing the cost model (even if it impacts other places) is the right thing to do here. We cannot accept such special cases in LICM.
Acknowledged and it makes sense to me. Is it more idiomatic to create a new revision (to update the cost model) or just modify this existing revision?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128302/new/
https://reviews.llvm.org/D128302
More information about the llvm-commits
mailing list