[PATCH] D114846: [llvm] [Debuginfod] LLVM debuginfod server.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added inline comments.


================
Comment at: llvm/tools/llvm-debuginfod/llvm-debuginfod.cpp:101
+    ExitOnErr(Collection.updateForever(
+        std::chrono::milliseconds(static_cast<int>(ScanInterval * 1000))));
+  Pool.wait();
----------------
mysterymath wrote:
> std::chrono::seconds? It looks like the implicit conversion should automatically convert the durations.
The goal of this was to allow someone to specify non-integer arguments, which would be rounded to the nearest millisecond. However I think it is more canonical to require an integer, so I've updated the argument and used your suggested conversion. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114846/new/

https://reviews.llvm.org/D114846