[PATCH] D128184: [lld-macho] Show source information for undefined references

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 13:45:36 PDT 2022


thakis added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1379
+std::string ObjFile::sourceFile() const {
+  if (!compileUnit)
+    return {};
----------------
Do we need this check? All current callers of sourceFile() check compileUnit before calling this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128184/new/

https://reviews.llvm.org/D128184



More information about the llvm-commits mailing list