[PATCH] D125263: [CMake][MSVC] Compile with `/permissive-`

Tue Jun 21 13:29:24 PDT 2022

aeubanks added a comment.

In D125263#3600114 <https://reviews.llvm.org/D125263#3600114>, @paulkirth wrote:

> Hi, we're seeing a build failure on windows that we've traced back to this revision.
>
> You can find the failing bot here: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8810806780048763729/overview
>
> The error is as follows:
>
>   FAILED: tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ScheduleTreeTransform.cpp.obj 
>   C:\b\s\w\ir\x\w\cipd\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GNU_SOURCE -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\polly\lib -IC:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib -Itools\polly\include -IC:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib\External -IC:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib\External\pet\include -IC:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib\External\isl\include -Itools\polly\lib\External\isl\include -IC:\b\s\w\ir\x\w\llvm-llvm-project\polly\include -IC:\b\s\w\ir\cache\vpython\a74aab\Lib\site-packages\tensorflow\include -Iinclude -IC:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include -IC:\b\s\w\ir\x\w\staging\zlib_install\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation /Gw -no-canonical-prefixes /EHs-c- /MT /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Fotools\polly\lib\CMakeFiles\obj.Polly.dir\Transform\ScheduleTreeTransform.cpp.obj /Fdtools\polly\lib\CMakeFiles\obj.Polly.dir\ -c C:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib\Transform\ScheduleTreeTransform.cpp
>   In file included from C:\b\s\w\ir\x\w\llvm-llvm-project\polly\lib\Transform\ScheduleTreeTransform.cpp:13:
>   In file included from C:\b\s\w\ir\x\w\llvm-llvm-project\polly\include\polly/ScheduleTreeTransform.h:16:
>   C:\b\s\w\ir\x\w\llvm-llvm-project\polly\include\polly/Support/ISLTools.h(59,36): error: no member named 'max' in namespace 'std'
>         : List(&List), Position(std::max(List.size().release(), 0)) {}
>                                 ~~~~~^
>   1 error generated.
>
> While this at first appeared to be a change in header dependencies, we bisected the failure down to this commit. It looks like there may be some subtle differences in the way the flags are used or propagated in `clang-cl`.
>
> Can you please take a look, and revert if it cannot be easily fixed?

I've pushed https://reviews.llvm.org/rGc80b88ee29f34078d2149de94e27600093e6c7c0 as a speculative fix, perhaps that will fix it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125263/new/

https://reviews.llvm.org/D125263