[PATCH] D114487: [LAA] Support runtime checks for select GEP base pointers.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 13:19:07 PDT 2022


vitalybuka added a comment.

In D114487#3593011 <https://reviews.llvm.org/D114487#3593011>, @fhahn wrote:

> In D114487#3555041 <https://reviews.llvm.org/D114487#3555041>, @vitalybuka wrote:
>
>> @fhahn 
>> This is reduced reproducer:
>
> Thanks! I think I was able to isolate the bits that caused problems:
>
> 1. Unecessarily looking through selects outside the loop
> 2. Introducing branches on undef/poison when looking through selects.
>
> I recommitted the change in e9cced27390ba38eac1144aa1240281a1edadec0 <https://reviews.llvm.org/rGe9cced27390ba38eac1144aa1240281a1edadec0>. I couldn't test with msan though, as it's not available on macOS. Please let me know if you see further issues.

Thanks! Out test works with e9cced27390ba38eac1144aa1240281a1edadec0 <https://reviews.llvm.org/rGe9cced27390ba38eac1144aa1240281a1edadec0>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114487/new/

https://reviews.llvm.org/D114487



More information about the llvm-commits mailing list