[PATCH] D127777: [ThinLTO][ELF] Add --thinlto-emit-index-files option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Allows ThinLTO indices to be written to disk on-the-fly/as-part-of “normal” linker execution. Previously thinLTO indices could be written via --thinlto-index-only but that would cause the linker to exit early.

Can you state the motivation for not exiting early? What files are needed for --thinlto-emit-index-files?



================
Comment at: lld/test/ELF/lto/thinlto-emit-index.ll:3
+
+; Mostly copied from thinlto-index-only
+; First ensure that the ThinLTO handling in lld handles
----------------
lld/test/ELF tests, at least the new ones, use `;; ` for non-RUN-non-CHECK lines. This makes the comments stand out and helps possibly future FileCheck feature to catch unused/misused check prefixes.


================
Comment at: lld/test/ELF/lto/thinlto-emit-index.ll:5
+; First ensure that the ThinLTO handling in lld handles
+; bitcode without summary sections gracefully and generates index file.
+; RUN: llvm-as %s -o %t1.o
----------------
Use `rm -rf %t && mkdir %t && cd %t`. This is more readable and less error-prone than many `rm -f %t*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127777/new/

https://reviews.llvm.org/D127777