[PATCH] D128295: [lld/mac] Replace while loop with for loop
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 12:37:01 PDT 2022
thakis added a comment.
In D128295#3599940 <https://reviews.llvm.org/D128295#3599940>, @tschuett wrote:
> Nit. Your are not allowed to check `getBlockCount()` for every iteration. Pull it out of the loop?
I don't understand what this means. Do you mean `i < getBlockCount()` in the loop conditional? Pretty sure all compilers strength-reduce this (e.g. https://godbolt.org/z/qjMW6cErh)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128295/new/
https://reviews.llvm.org/D128295
More information about the llvm-commits
mailing list