[PATCH] D128295: [lld/mac] Replace while loop with for loop
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 12:17:45 PDT 2022
thakis created this revision.
thakis added a reviewer: lld-macho.
Herald added projects: lld-macho, All.
thakis requested review of this revision.
No behavior change. In preparation for using a parallelFor() here.
https://reviews.llvm.org/D128295
Files:
lld/MachO/SyntheticSections.cpp
Index: lld/MachO/SyntheticSections.cpp
===================================================================
--- lld/MachO/SyntheticSections.cpp
+++ lld/MachO/SyntheticSections.cpp
@@ -1253,14 +1253,11 @@
void CodeSignatureSection::writeHashes(uint8_t *buf) const {
// NOTE: Changes to this functionality should be repeated in llvm-objcopy's
// MachOWriter::writeSignatureData.
- uint8_t *code = buf;
- uint8_t *codeEnd = buf + fileOff;
- uint8_t *hashes = codeEnd + allHeadersSize;
- while (code < codeEnd) {
- sha256(code, std::min(static_cast<size_t>(codeEnd - code), blockSize),
- hashes);
- code += blockSize;
- hashes += hashSize;
+ uint8_t *hashes = buf + fileOff + allHeadersSize;
+ for (uint64_t i = 0; i < getBlockCount(); ++i) {
+ sha256(buf + i * blockSize,
+ std::min(static_cast<size_t>(fileOff - i * blockSize), blockSize),
+ hashes + i * hashSize);
}
#if defined(__APPLE__)
// This is macOS-specific work-around and makes no sense for any
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128295.438796.patch
Type: text/x-patch
Size: 1015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220621/a4667a03/attachment.bin>
More information about the llvm-commits
mailing list