[PATCH] D126313: [CMake] Don't pass CMAKE_C(XX)_COMPILER to the nested NATIVE build

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 11:57:54 PDT 2022


mstorsjo added a comment.

In D126313#3599863 <https://reviews.llvm.org/D126313#3599863>, @beanz wrote:

> I think this behavior change should only be made if `CMAKE_CROSSCOMPILING=True`. There are common cases where people configure LLVM targeting the host using a compiler that isn't the default host compiler (think compiling on Linux using clang). Since the `Native` toolchain is also used for using optimized tablegen when building a debug configuration, this code isn't strictly for cross-compilation.

Oh, thanks, that's a good point - I hadn't considered that case!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126313/new/

https://reviews.llvm.org/D126313



More information about the llvm-commits mailing list