[PATCH] D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:447-456
+
+  decltype(auto) operator*() const {
+    assert(BaseT::wrapped() != End && "Cannot dereference end iterator!");
+    return BaseT::operator*();
+  }
+
+  decltype(auto) operator->() const {
----------------
int3 wrote:
> int3 wrote:
> > this seems like it should be a separate commit
> (but if thakis thinks it's fine then I guess it is)
(bertaland suggested making it a separate commit originally, but I thought it'd be nice to have assert and fix in one change (?))


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128294/new/

https://reviews.llvm.org/D128294