[PATCH] D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 11:34:16 PDT 2022


int3 added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:447-456
+
+  decltype(auto) operator*() const {
+    assert(BaseT::wrapped() != End && "Cannot dereference end iterator!");
+    return BaseT::operator*();
+  }
+
+  decltype(auto) operator->() const {
----------------
int3 wrote:
> this seems like it should be a separate commit
(but if thakis thinks it's fine then I guess it is)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128294/new/

https://reviews.llvm.org/D128294



More information about the llvm-commits mailing list