[PATCH] D128159: [DAG] Enable scalable vectors handling in computeKnownBits

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 09:45:38 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2912
   KnownBits Known(BitWidth);   // Don't know anything.
 
   if (auto *C = dyn_cast<ConstantSDNode>(Op)) {
----------------
should we assert here?
```
assert((!Op.getValueType().isScalableVector() || DemandedElts.isAllOnes()) && "All scalable vector elements must be demanded");
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128159/new/

https://reviews.llvm.org/D128159



More information about the llvm-commits mailing list