[PATCH] D128272: [LoopVectorize] Change PredicatedBBsAfterVectorization to be per VF

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 07:58:02 PDT 2022


sdesmalen added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-cost.ll:8
+
+define dso_local i32 @uniform_load(i64 %n, i64 %boff, i64 %coff, ptr nocapture readonly %b, ptr nocapture readnone %c) #0 {
+; CHECK: LAA: Found a loop in uniform_load: for.body
----------------
nit: can you clean up this test a bit? `dso_local` `nocapture`, etc aren't really required for the LV test.
Also, can you use some constant FP value instead of loading from `@globval` ?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-cost.ll:16
+
+for.body:                                         ; preds = %for.body, %for.body
+  %indvars.iv = phi i64 [ 1, %entry ], [ %indvars.iv.next, %for.body ]
----------------
What in this loop is causing `PredicatedBBsAfterVectorization` to be `true` for fixed-width vectors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128272/new/

https://reviews.llvm.org/D128272



More information about the llvm-commits mailing list