[PATCH] D128193: AMDGPU: Skip unexpected CFG in SIOptimizeVGPRLiveRange

[Carl Ritson via Phabricator via llvm-commits]

critson accepted this revision.
critson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/AMDGPU/opt-vgpr-live-range-verifier-error.mir:4
+# This is a very rare case which comes from llvm-reduce. The SI_IF/SI_ELSE usage is quite different from normal.
+# It is sad we do not specify the semantics of these control flow intrinsics, which I think we should have one.
+# CHECK-LABEL: name: unusual_if_else
----------------
I echo your sentiments, but I am not sure this comment is helpful in the test file.  Perhaps remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128193/new/

https://reviews.llvm.org/D128193