[PATCH] D125114: [SimplifyLibCalls] handle subobjects of constant aggregates

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1182
+      // let sanitizers catch it.
+      return nullptr;
+
----------------
I assume this is done to preserve some existing test behavior?


================
Comment at: llvm/test/Transforms/InstCombine/strlen-8.ll:40
 
 ; Fold strlen(&a5_4[2][I]) to i <= 1 ? 1 - I : 0.
 
----------------
This is actually folding `strlen(&a5_4[2][1])` -- probably not intentional?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125114/new/

https://reviews.llvm.org/D125114