[PATCH] D125212: [GlobalISel] Implement the Has{No}Use builtin predicates
Abinav Puthan Purayil via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 20 21:52:53 PDT 2022
abinavpp added inline comments.
================
Comment at: llvm/test/TableGen/GlobalISelEmitter-HasUse.td:45
+
+let HasUse = true in
+defm atomic_load_add_ret : binary_atomic_op<atomic_load_add>;
----------------
arsenm wrote:
> foad wrote:
> > A philosophical question: do we really need HasUse? After all the atomic_load_add_ret pattern will still work in both cases (use & nouse), so shouldn't we use priorities instead to prefer the atomic_load_add_no_ret pattern when both are applicable?
> Yes, having one predicate and priorities would be more consistent
D128241
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125212/new/
https://reviews.llvm.org/D125212
More information about the llvm-commits
mailing list