[PATCH] D128235: [RISCV] Add support for the Zawrs extension

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 21:04:41 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/test/MC/RISCV/zawrs-invalid.s:4
+# WRS doesn't take immediates
+wrs 1 # CHECK: :[[@LINE]]:5: error: invalid operand for instruction
+
----------------
`[[@LINE]]` is a deprecated FileCheck feature.

Use `[[#@LINE]]`

Note: you can place negative tests with the positive test file. Search `.ifndef err`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128235/new/

https://reviews.llvm.org/D128235



More information about the llvm-commits mailing list