[PATCH] D128235: [RISCV] Add support for the Zawrs extension
    Yueh-Ting (eop) Chen via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jun 20 17:47:16 PDT 2022
    
    
  
eopXD added a comment.
- I think we will need some test coverage under `llvm/test/CodeGen/RISCV/attributes.ll` and `llvm/test/MC/RISCV/attribute-arch.s` if the extension is existing in the arch string.
- Since macro is added, we need some test coverage under `clang/test/Preprocessor/riscv-target-features.c`
- There is also some test case for error handling under `clang/test/Driver/riscv-arch.c`, maybe add some there too?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128235/new/
https://reviews.llvm.org/D128235
    
    
More information about the llvm-commits
mailing list