[PATCH] D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 10:01:26 PDT 2022


kzhuravl added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:493
+  if (Src1->isReg())
+    MRI.clearKillFlags(Src1->getReg());
+
----------------
arsenm wrote:
> Can you get away with clearing it on the one operand?
In the case I was looking at - yes. However, better to clear on both. Updated and added the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127768/new/

https://reviews.llvm.org/D127768



More information about the llvm-commits mailing list