[PATCH] D127858: [RISCV] Turn on SeparateConstOffsetFromGEPPass for RISC-V target

[Elena Lepilkina via Phabricator via llvm-commits]

eklepilkina added a comment.

> Are you seeing any instances of worse code in any of the tests / benchmarks you're looking at?

Yes, I ran almost all llvm test-suite benchmarks. There were some unstable benchmarks, but regressions on them weren't reproduced in the next runs. Do you have the cases with previous regressions you've found out?

> Presumably the changes in D127727 <https://reviews.llvm.org/D127727> were motivated by such cases?

Exactly, besides unstable cases we also found several regressions and my investigation mostly shows that the current pass originally modifies all GEPs althought sometimes it increase register pressure, so new startegy was added. Of course, it's possible I missed something.

I'll be grateful if you provide some list of benchmarks that I should pay more attention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127858/new/

https://reviews.llvm.org/D127858