[PATCH] D128174: [DebugInfo][InstrRef][NFC Update LDV to use generic DBG_VALUE* MI interface

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:461
 
-    PendingDbgValues.push_back(emitMOLoc(MO, Var, {NewExpr, Prop.Indirect}));
+    PendingDbgValues.push_back(
+        emitMOLoc(MO, Var, {NewExpr, Prop.Indirect, false}));
----------------
I would consider adding `assert(!Prop.IsVariadic)` above this line (or changing the `emitMOLoc` call to `emitMOLoc(MO, Var, {NewExpr, Prop.Indirect, Prop.IsVariadic})` (or both), so that this line doesn't get out of sync with the if statement added at the start of this function, but YMMV - feel free to ignore this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128174/new/

https://reviews.llvm.org/D128174