[PATCH] D126623: [XCOFF] write the real source file name in C_FILE symbol.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 03:30:23 PDT 2022


shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM with nits. Thanks for fixing this.



================
Comment at: llvm/test/MC/PowerPC/aix-file-symbols-empty.s:6
+      .globl var1
+var1:
+      .globl var2
----------------
nit: var1 and var2 are both function entries by default. We need to name them as `.var1` and `.var2`.


================
Comment at: llvm/test/MC/PowerPC/aix-file-symbols.s:10
+      .globl var2
+var2:
+      .file   "3.c"
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126623/new/

https://reviews.llvm.org/D126623



More information about the llvm-commits mailing list