[PATCH] D128172: [SLP] Add cost models for llvm.powi.* intrinsics

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

diff with context?



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2204
+  /// 5 multiplies and a divide (if the exponent is negative).
+  virtual bool isBeneficialToExpandPowI(unsigned int Exponent, bool OptForSize) const {
+    if ((int)Exponent < 0)
----------------
Maybe drop the virtual - its easy enough to readd if a target wants to override this.

Would this be better as int Exponent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128172/new/

https://reviews.llvm.org/D128172