[PATCH] D128169: [Alignment] Use 'previous()' method instead of scalar division

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 02:52:38 PDT 2022


tschuett added inline comments.


================
Comment at: llvm/include/llvm/Support/Alignment.h:87
 
+  // Returns the previous aAlignment.
+  auto previous() const {
----------------
Alignment without the `a`.


================
Comment at: llvm/include/llvm/Support/Alignment.h:88
+  // Returns the previous aAlignment.
+  auto previous() const {
+    assert(ShiftValue != 0 && "Undefined operation");
----------------
Please remove the `auto`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128169/new/

https://reviews.llvm.org/D128169



More information about the llvm-commits mailing list