[PATCH] D128164: [LoopPeel] Forget SCEV for updated exit phi values.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 02:28:05 PDT 2022


fhahn added a comment.

In D128164#3595684 <https://reviews.llvm.org/D128164#3595684>, @nikic wrote:

> This looks reasonable to me -- only thing that's not entirely clear to me is why forgetTopmostLoop() doesn't end up doing this. The forgetLoop() implementation is very aggressive, and I would have expected that the use-def walk would reach the exit phis as well.

It looks like `forgetLoop` only invalidates uses of AddRecs, headers phis and BTC users. The problematic phi here is `%lcssa.1 ` which is not reachable through any of the roots `forgetLoop` uses for invalidation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128164/new/

https://reviews.llvm.org/D128164



More information about the llvm-commits mailing list