[PATCH] D122539: [SelectionDAG][DAGCombiner] Reuse exist node by reassociate

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 01:27:44 PDT 2022


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - with one more style minor



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1037
+      auto *LoadStore = dyn_cast<MemSDNode>(Node);
+      if (LoadStore) {
+        // Is x[offset2] already not a legal addressing mode? If so then
----------------
```
if (auto *LoadStore = dyn_cast<MemSDNode>(Node);)
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122539/new/

https://reviews.llvm.org/D122539



More information about the llvm-commits mailing list