[PATCH] D127447: [RISCV] Cost model for scalable reductions

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 00:22:48 PDT 2022


liaolucy added a comment.

In D127447#3591261 <https://reviews.llvm.org/D127447#3591261>, @craig.topper wrote:

> In D127447#3590942 <https://reviews.llvm.org/D127447#3590942>, @liaolucy wrote:
>
>> Don't we need to qualify Opcode?
>>
>> D126372 <https://reviews.llvm.org/D126372>,  I tried to implement a preliminary support, referring to other architectures limiting some opcode
>
> Isn't the opcode checked on line 356?
>
>   if (ISD != ISD::ADD && ISD != ISD::OR && ISD != ISD::XOR && ISD != ISD::AND &&
>         ISD != ISD::FADD)

I see. Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127447/new/

https://reviews.llvm.org/D127447



More information about the llvm-commits mailing list