[PATCH] D127963: [AMDGPU] Add support for GFX11 LDSDIR hazards

Mon Jun 20 00:15:57 PDT 2022

foad marked 2 inline comments as done.
foad added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/lds-direct-hazards.mir:4
+# GCN-LABEL: name: lds_param_load_no_war
+# GCN: LDS_PARAM_LOAD 0, 0, 15
+---
----------------
critson wrote:
> foad wrote:
> > rampitec wrote:
> > > This check does not mean there is no wait. Either use GCN-NEXT, or just generate the checks.
> > @critson this was yours originally - any preference on how to write this test?
> This is testing that the LDS_PARAM_LOAD has the correct value for wait_vdst (last operand) not explicitly that there is no S_WAITCNT; however, it could make sense to do that too.
> In which case we might as well generate the test now.
> 
OK, done!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127963/new/

https://reviews.llvm.org/D127963