[PATCH] D127938: Update Windows packaging script.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:184
+
+  7z x -y LLVM-%package_version%-win32.exe -orepack
+  rmdir /s /q repack\$PLUGINSDIR
----------------
CarlosAlbertoEnciso wrote:
> thieta wrote:
> > CarlosAlbertoEnciso wrote:
> > > hans wrote:
> > > > Since it takes quite a while to run, can this repackaging step be put behind a flag?
> > > Any specific name for the flag?
> > CompressInstaller maybe?
> I am proposing to use long option names to accomodate the `CompressInstaller`, `build_dir_base` and `LogPath or TestLogPath` cases:
> 
> 
> ```
> --build-32    --build-64     # build step
> --test-32     --test-64      # test step
> --pack-32     --pack-64      # package step
> --repack-32   --repack-64    # repackagin step
> 
> --trace                      # debugging trace
> --base-dir                   # build directory base
> --log-file                   # log filename (in the same build directory) 
> ```
Usage test:

```

Script for building the LLVM installer on Windows, used for
the releases at https://github.com/llvm/llvm-project/releases

Usage: build_llvm_release.bat <options>

options:
--version [<number>]  Version number (i.e. 14.0.4)
--base-dir <name>     Build base directory
--log-file <name>     Log filename

--build-32            Build 32-bit binaries
--build-64            Build 64-bit binaries
--test-32             Run 32-bits tests
--test-64             Run 64-bits tests

--pack-32             Create 32-bits binary package
--pack-64             Create 64-bits binary package
--repack-32           Repack 32-bits binary package
--repack-64           Repack 64-bits binary package

--trace               Debugging trace

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127938/new/

https://reviews.llvm.org/D127938