[llvm] 8780630 - [RISCV] Merge two similar asserts from different if/else blocks. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 19 19:49:14 PDT 2022
Author: Craig Topper
Date: 2022-06-19T19:48:50-07:00
New Revision: 8780630ded2eee7a07bed12d15849826a151f17a
URL: https://github.com/llvm/llvm-project/commit/8780630ded2eee7a07bed12d15849826a151f17a
DIFF: https://github.com/llvm/llvm-project/commit/8780630ded2eee7a07bed12d15849826a151f17a.diff
LOG: [RISCV] Merge two similar asserts from different if/else blocks. NFC
Added:
Modified:
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
index acaf72263dd02..bb62e90b4bfcd 100644
--- a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
@@ -2383,27 +2383,18 @@ bool RISCVDAGToDAGISel::doPeepholeMaskedRVV(SDNode *N) {
}
}
- if (IsTA) {
- uint64_t TSFlags = TII.get(I->UnmaskedPseudo).TSFlags;
-
- // Check that we're dropping the merge operand, the mask operand, and any
- // policy operand when we transform to this unmasked pseudo.
- assert(!RISCVII::hasMergeOp(TSFlags) && RISCVII::hasDummyMaskOp(TSFlags) &&
- !RISCVII::hasVecPolicyOp(TSFlags) &&
- "Unexpected pseudo to transform to");
- (void)TSFlags;
- } else {
- uint64_t TSFlags = TII.get(I->UnmaskedTUPseudo).TSFlags;
-
- // Check that we're dropping the mask operand, and any policy operand
- // when we transform to this unmasked tu pseudo.
- assert(RISCVII::hasMergeOp(TSFlags) && RISCVII::hasDummyMaskOp(TSFlags) &&
- !RISCVII::hasVecPolicyOp(TSFlags) &&
- "Unexpected pseudo to transform to");
- (void)TSFlags;
- }
-
unsigned Opc = IsTA ? I->UnmaskedPseudo : I->UnmaskedTUPseudo;
+
+ // Check that we're dropping the mask operand and any policy operand
+ // when we transform to this unmasked pseudo. Additionally, if this insturtion
+ // is tail agnostic, the unmasked instruction should not have a merge op.
+ uint64_t TSFlags = TII.get(Opc).TSFlags;
+ assert((IsTA != RISCVII::hasMergeOp(TSFlags)) &&
+ RISCVII::hasDummyMaskOp(TSFlags) &&
+ !RISCVII::hasVecPolicyOp(TSFlags) &&
+ "Unexpected pseudo to transform to");
+ (void)TSFlags;
+
SmallVector<SDValue, 8> Ops;
// Skip the merge operand at index 0 if IsTA
for (unsigned I = IsTA, E = N->getNumOperands(); I != E; I++) {
More information about the llvm-commits
mailing list