[PATCH] D126623: [XCOFF] write the real source file name in C_FILE symbol.

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/test/MC/PowerPC/aix-symtbl-order.s:7
+      .file   "1.c"
+      .globl foo
+foo:
----------------
We are over design here? Like what we discussed offline, AIX assembler does not have the functionality to guarantee that the local/global symbols are associated with their precedent `.file` directive. I think it is better for us to do as AIX assembler does, just generate the C_FILE symbols for each `.file` and don't do any symbol scope related handling.


================
Comment at: llvm/test/MC/PowerPC/aix-symtbl-order.s:8
+      .globl foo
+foo:
+      blr
----------------
Nit: for function entry, we need to make it like `.foo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126623/new/

https://reviews.llvm.org/D126623