[PATCH] D127903: [InstCombine] Optimize test for same-sign of values

Sun Jun 19 07:51:13 PDT 2022

emgullufsen added a comment.

In D127903#3594645 <https://reviews.llvm.org/D127903#3594645>, @spatel wrote:

> I committed the tests with baseline results, so we have those in place independently of the code change. I then updated the tests to provide a bit more coverage. Please rebase/update after:
> feb4b336acc71 <https://reviews.llvm.org/rGfeb4b336acc7100fbb87fdd8f61f1d58cd234709>

Sounds good will do, thank you!

It's programmer preference, but I think it'd be easier to read with less IsAnd ? () :() constructs, so something like this:

> 

Sounds good, I prefer with less ternary operator as well - I had been a bit myopic about only building the returned instructions (calling Builder.CreateXor and the like) once. This is definitely nicer without so many conditionals - will amend in updated diff. Thank you for the diff (and copious help) as well!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127903/new/

https://reviews.llvm.org/D127903