[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/docs/Extensions.rst:399
+``SHT_LLVM_BB_ADDR_MAP`` and ``SHT_LLVM_BB_ADDR_MAP_V0`` Sections (basic block address map)
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 This section stores the binary address of basic blocks along with other related
----------------
jhenderson wrote:
> Does this need extending?
I interpreted your comment as we should remove it. Did you mean we should add a separate extension for this?


================
Comment at: llvm/lib/Object/ELF.cpp:669-672
+      if (Version > 1) {
+        return createError("unsupported LLVM_BB_ADDR_MAP version: " +
+                           Twine(static_cast<int>(Version)));
+      }
----------------
jhenderson wrote:
> Nit: no need for braces here.
Also removed braces elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121346/new/

https://reviews.llvm.org/D121346