[PATCH] D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned
Mingming Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 18 15:19:18 PDT 2022
mingmingl updated this revision to Diff 438155.
mingmingl retitled this revision from "[Support] Change TrackingStatistic to use uint64_t instead of unsigned" to "[Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned".
mingmingl added a comment.
Herald added a reviewer: bollu.
1. Change NoopStatistic to use uint64_t, to use consistent type for TrackingStatistic and NoopStatistic.
- If type isn't consistent, a user of Statistic class would compile when using one statistic type but fail to compile when using the other statistic type. See example usage in https://github.com/llvm/llvm-project/blob/6dd094dd435d09872687c1bdcce6845f70cf25cc/llvm/lib/Transforms/Scalar/NewGVN.cpp#L3409
2. Update uint64_t usage in `polly` sub-projects accordingly.
- This is caught by premerge-test, and not covered by previous `ninja check-all` when `polly` wasn't specified in `DLLVM_ENABLE_PROJECTS`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128070/new/
https://reviews.llvm.org/D128070
Files:
llvm/include/llvm/ADT/Statistic.h
llvm/lib/Support/Statistic.cpp
llvm/lib/Transforms/Scalar/NewGVN.cpp
llvm/unittests/ADT/StatisticTest.cpp
mlir/lib/Pass/PassStatistics.cpp
polly/lib/Analysis/ScopDetection.cpp
polly/lib/Analysis/ScopInfo.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128070.438155.patch
Type: text/x-patch
Size: 8634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220618/108ab511/attachment.bin>
More information about the llvm-commits
mailing list