[PATCH] D128122: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/pr56103.ll:6
+
+ at e = dso_local local_unnamed_addr global i16 0, align 2
+ at a = dso_local local_unnamed_addr global i32 0, align 4
----------------
Drop dso_local and unnamed-addr


================
Comment at: llvm/test/CodeGen/X86/pr56103.ll:49
+
+!0 = !{i32 1, !"wchar_size", i32 4}
+!1 = !{i32 7, !"PIC Level", i32 2}
----------------
Can we clean up the attributes and metadata nodes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128122/new/

https://reviews.llvm.org/D128122