[PATCH] D128093: [lld-macho] Initial support for Linker Optimization Hints

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 18 11:01:29 PDT 2022


tschuett added inline comments.


================
Comment at: lld/MachO/Arch/ARM64.cpp:168
+
+struct ADD {
+  uint8_t destRegister;
----------------
You could move the ADD into the anonymous namespace above.


================
Comment at: lld/MachO/Arch/ARM64.cpp:239
+}
+} // namespace
+
----------------
Why are the static functions in an anonymous namespace?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128093/new/

https://reviews.llvm.org/D128093



More information about the llvm-commits mailing list