[llvm] 37185ce - [Object] Make IsLittleEndian check constexpr to silence static analyzer dead code warnings.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2022-06-18T17:35:54+01:00
New Revision: 37185ceac9bccaeec7bfe8b42c00ad119ab70955

URL: https://github.com/llvm/llvm-project/commit/37185ceac9bccaeec7bfe8b42c00ad119ab70955
DIFF: https://github.com/llvm/llvm-project/commit/37185ceac9bccaeec7bfe8b42c00ad119ab70955.diff

LOG: [Object] Make IsLittleEndian check constexpr to silence static analyzer dead code warnings.

The "ELFT::TargetEndianness == support::little" check is known at compile time

Added: 
    

Modified: 
    llvm/include/llvm/Object/ELFObjectFile.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Object/ELFObjectFile.h b/llvm/include/llvm/Object/ELFObjectFile.h
index f90d4c0de25fc..c449a3dafc0ce 100644
--- a/llvm/include/llvm/Object/ELFObjectFile.h
+++ b/llvm/include/llvm/Object/ELFObjectFile.h
@@ -1174,7 +1174,7 @@ uint8_t ELFObjectFile<ELFT>::getBytesInAddress() const {
 
 template <class ELFT>
 StringRef ELFObjectFile<ELFT>::getFileFormatName() const {
-  bool IsLittleEndian = ELFT::TargetEndianness == support::little;
+  constexpr bool IsLittleEndian = ELFT::TargetEndianness == support::little;
   switch (EF.getHeader().e_ident[ELF::EI_CLASS]) {
   case ELF::ELFCLASS32:
     switch (EF.getHeader().e_machine) {