[PATCH] D127903: [InstCombine] Optimize test for same-sign of values

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 18 07:16:37 PDT 2022


spatel added a comment.

In D127903#3594030 <https://reviews.llvm.org/D127903#3594030>, @emgullufsen wrote:

> Fixed one more incorrect use of capturing in CHECK line.

Did you generate the CHECK lines manually? We don't want to do that generally. 
Sorry - I should have mentioned this earlier, but we prefer to use a script that is shown on the first line of the test file :
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127903/new/

https://reviews.llvm.org/D127903



More information about the llvm-commits mailing list