[PATCH] D128094: [WebAssembly][Object] Remove requirement that objects must have code sections
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 17 13:29:06 PDT 2022
sbc100 added inline comments.
================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:526
- object_error::parse_failed);
- }
----------------
What happens if the linking metdata comes before the code section now? Is that OK?
================
Comment at: llvm/test/tools/llvm-objdump/wasm/no-codesec.test:26
+ - Index: 0
+ Name: foo
----------------
This is no longer a valid wasm file though right? Since it refers to a function that doesn't have a body. I guess that is maybe ok as long as we produce valid wasm files by default?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128094/new/
https://reviews.llvm.org/D128094
More information about the llvm-commits
mailing list