[PATCH] D128092: [BOLT] Fix for missing entry offset

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 13:06:36 PDT 2022


rafauler created this revision.
Herald added a subscriber: ayermolo.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
rafauler requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Temporary fix for missing entry offset when creating address
translation tables (BAT) after D127935 <https://reviews.llvm.org/D127935> landed. Will later work on
assigning a more reasonable offset different than zero.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128092

Files:
  bolt/lib/Passes/ValidateInternalCalls.cpp


Index: bolt/lib/Passes/ValidateInternalCalls.cpp
===================================================================
--- bolt/lib/Passes/ValidateInternalCalls.cpp
+++ bolt/lib/Passes/ValidateInternalCalls.cpp
@@ -106,6 +106,7 @@
         // block.
         std::vector<std::unique_ptr<BinaryBasicBlock>> NewBBs;
         NewBBs.emplace_back(Function.createBasicBlock());
+        NewBBs.back()->setOffset(0);
         NewBBs.back()->addInstructions(MovedInsts.begin(), MovedInsts.end());
         BB.moveAllSuccessorsTo(NewBBs.back().get());
         Function.insertBasicBlocks(&BB, std::move(NewBBs));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128092.438024.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220617/ab11bd21/attachment.bin>


More information about the llvm-commits mailing list