[PATCH] D128075: [AMDGPU][MC][GFX11] Correct disassembly of DPP variants of VOPC64 opcodes

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 11:31:26 PDT 2022


Joe_Nash added a comment.

Overall looks good, thanks!



================
Comment at: llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp8.txt:1
+# RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=+wavefrontsize32,-wavefrontsize64 -disassemble -show-encoding < %s | FileCheck %s --check-prefix=GFX11
+
----------------
I see we only had wave32 before on these tests. Can you add wave64?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128075/new/

https://reviews.llvm.org/D128075



More information about the llvm-commits mailing list