[PATCH] D128029: [AArch64] Add target feature "all"

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 10:44:26 PDT 2022


MaskRay added a comment.

In D128029#3592617 <https://reviews.llvm.org/D128029#3592617>, @nickdesaulniers wrote:

> Do we have equivalent "all" features for other architectures? It might be nice to have an interface architectures can provide to list a list of all possible features.  Then we have one place to keep up to date, then other call sites can share that code.  That might help us notice sooner when the "all" list is missing a new addition if there's more than one user, eventually.

PowerPC has -mcpu=future (see D127824 <https://reviews.llvm.org/D127824>). Note that some targets may have conflicting instruction sets, at which point an `all` feature will not exist. (IIRC PowerPC's Signal Processing Engine extension falls into this case).
We may have several choices of `all`: (a) great common divisor (b) all target features user mostly likely expect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128029/new/

https://reviews.llvm.org/D128029



More information about the llvm-commits mailing list