[PATCH] D126977: [config] Remove vestigial LLVM_VERSION_INFO

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D126977#3590611 <https://reviews.llvm.org/D126977#3590611>, @arphaman wrote:

> @rnk this is option is needed to vendor the Apple clang toolchain in Xcode. Unfortunately we don't have any references to it in the upstream llvm-project repo, but this is breaking our downstream integration. Can this be reverted?

I'd prefer not to, if possible, since changing config.h.cmake churns all three in-tree build systems and any out-of-tree build systems. You should be able to get the old behavior by appending your definition of LLVM_VERSION_INFO to PACKAGE_VERSION. Does that work for you? We actually had the same problem at Google, coincidentally, and that's what we did.

Were you using LLVM_VERSION_INFO to embed the VCS revision? If yes, and we want the open source tools to do this, we should have the CommandLine.cpp --version code use the VCSRevision.h header. I think this may interact badly with tablegen, since every update to git HEAD will then modify Support, which llvm-blgen uses, which will invalidate all tablegen runs. Maybe we can fix that somehow. It's a bunch of work, but that's probably the best, most proper solution.

Anyway, I think it's best if everyone tries to align their internal integrations as much as possible with what the open source build supports, and that we don't have config options like this that are only exercised by out of tree builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126977/new/

https://reviews.llvm.org/D126977