[PATCH] D127664: [AMDGPU] gfx11 ldsdir intrinsics and ISel

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1491
 
+// __int_amdgcn_lds_direct_load <m0>
+// The input argument is m0, which contains a packed combination of address
----------------
foad wrote:
> The __int_* prefix doesn't make much sense. I would suggest either using the tablegen name (int_amdgcn_lds_direct_load) or preferably the LLVM IR name (llvm.amdgcn.lds.direct.load).
Done, see
75378d432fda5408b7210fd3627db884561db650


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127664/new/

https://reviews.llvm.org/D127664